Intermittent CI test failure

[esabol]

This test in t/client suddenly has started to fail frequently but not always:

tests/libgearman-1.0/client_test.cc:821: in hostname_resolution() pid(37552) Assertion 'GEARMAN_COULD_NOT_CONNECT' != 'gearman_client_echo(&client, test_literal_param("foo"))' client.gearman_client_st.gearman_client_add_servers(GEARMAN_GETADDRINFO) [ failed ]

That corresponds to this code:

gearmand/tests/libgearman-1.0/client_test.cc

Lines 821 to 822 in c24d899

	ASSERT_EQ(GEARMAN_COULD_NOT_CONNECT,
	gearman_client_echo(&client, test_literal_param("foo")));

In what scenario would that ASSERT_EQ() fail?

[esabol]

Actually, more often than not the CI workflow will just hang for a long time – 30+ minutes is not uncommon – before it finally fails that test.

[esabol]

A couple lines earlier before the test that intermittently fails is this skipped test:

gearmand/tests/libgearman-1.0/client_test.cc

Line 813 in c24d899

test_skip(GEARMAN_SUCCESS, gearman_client_add_servers(&client, "exist.gearman.info:12345"));

Does a skipped test still execute the code? I think so? test_skip is a #define which does a do { ... } while (0);

So that means the failing test is trying to send foo to exist.gearman.info:12345?

[esabol]

It took 12 attempts, but I finally got all of the CI workflow jobs to pass.

I'm tempted to just disable all of these hostname_resolution() tests in CI.

[esabol]

I suspect this issue may have been fixed by changing the *.gearman.info hostnames in the test suite to *.gearman.org, but I'll leave this open until I have more data.