Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Invalid date params getting through to Date constructor #2566

Open
katjam opened this issue Aug 19, 2024 · 3 comments · Fixed by #2569
Open

[Bug]: Invalid date params getting through to Date constructor #2566

katjam opened this issue Aug 19, 2024 · 3 comments · Fixed by #2569
Labels
bug Release Drafter category - bug impacting the normal functioning of existing features good first issue

Comments

@katjam
Copy link
Member

katjam commented Aug 19, 2024 •
edited by huly-for-github bot
Loading

Description

Reported on rollbar. 7052 times between 2024-04-06 and 2024-08-19

https://app.rollbar.com/a/gfsc/fix/item/placecal-production/415

image
@katjam katjam added the bug Release Drafter category - bug impacting the normal functioning of existing features label Aug 19, 2024
@kimadactyl
Copy link
Member

This is also being caused by Bytespider trying random URLs

@kimadactyl kimadactyl mentioned this issue Aug 19, 2024
Merged
@katjam
Copy link
Member Author

katjam commented Aug 21, 2024

Shouldn't we still guard against this by not trying to generate a date if we don't have the valid input? There may be other instances where this can occur.

@kimadactyl
Copy link
Member

will reopen but take off the milestone

@kimadactyl kimadactyl reopened this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Release Drafter category - bug impacting the normal functioning of existing features good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add robots.txt to ask AI bots not to crawl the site geeksforsocialchange/PlaceCal
2 participants
@kimadactyl @katjam