Add pull request template for PlaceCal

[lenikadali]

Checklist:

• I have performed a self-review of my own code,
• I have commented my code, particularly in hard-to-understand areas,
• I have made corresponding changes to the documentation,
• I have added tests that prove my fix is effective or that my feature works,
• New and existing unit tests pass locally with my changes
• Title include "WIP" if work is in progress.

Resolves #2501

Description

Motivation and Context

The PR aims to provide a pull request template that makes it easy for new contributors to the project to provide details regarding what their pull request does. It also helps reviewers easily and quickly understand what the pull request is meant to do and review it with the appropriate context in mind.

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

How Has This Been Tested?

By viewing the resulting markdown file.

How Will This Be Deployed?

N/A

Screenshots

N/A

[kimadactyl]

Hey this is looking great!

There's a bunch of things noted down in the linked ticket - do you think any of them are worth pulling through?

[lenikadali]

@kimadactyl this should be good to go now. Thanks for the review 🙌🏿

[kimadactyl]

@kimadactyl this should be good to go now. Thanks for the review 🙌🏿

Did you have a look at the linked ticket and do you think those issues are either represented or not needed?

[lenikadali]

@kimadactyl this should be good to go now. Thanks for the review 🙌🏿

Did you have a look at the linked ticket and do you think those issues are either represented or not needed?

I think not needed. The other items could be moved into a separate guide on how to interact with pull requests, both for contributors and reviewers. That's how I've seen it done in other projects. Also can't confirm now but things like console.log statements should be covered out of the box by linters (ESLint, RuboCop etc.)

Edit: also something like changing to view components is ticket specific so that would be added to the ticket for context to whoever ends up working on the feature.

[kimadactyl]

OK great, happy to merge then :)

[kimadactyl]

Ugh #2556 is happening again, so annoying!