From a9fd039a83972ddb328ea8050059905f1c65cee2 Mon Sep 17 00:00:00 2001
From: Leni Kadali <52788034+lenikadali@users.noreply.github.com>
Date: Tue, 22 Oct 2024 12:56:58 +0300
Subject: [PATCH 1/2] Add pull request template

Added pull request template for PlaceCal
---
 .github/PULL_REQUEST_TEMPLATE.md | 53 ++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 .github/PULL_REQUEST_TEMPLATE.md

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 000000000..f9e3db5f9
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,53 @@
+<!--- Provide a general summary of your changes in the Title above -->
+<!--Read comments, before committing pull request read checklist again
+
+# Checklist:
+
+- [ ] I have performed a self-review of my own code,
+- [ ] I have commented my code, particularly in hard-to-understand areas,
+- [ ] I have made corresponding changes to the documentation,
+- [ ] I have added tests that prove my fix is effective or that my feature works,
+- [ ] New and existing unit tests pass locally with my changes
+- [ ] Title include "WIP" if work is in progress.
+-->
+
+Resolves # <!--fill issue number-->
+
+## Description
+
+<!--- Describe your changes in detail -->
+
+### Motivation and Context
+
+<!--- Why is this change required? What problem does it solve? -->
+<!--- If it fixes an open issue, please link to the issue here. -->
+
+<!--- If there's a Figma file or similar spec, please link to to the issue. List any dependencies that are required for this change. (gems, js libraries, etc.)
+
+Include anything else we should know about.-->
+
+### Type of change
+
+<!-- Please delete options that are not relevant. -->
+
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality to change)
+- [ ] This change requires a documentation update
+- [ ] Documentation update
+
+### How Has This Been Tested?
+
+<!--- Please describe in detail how you tested your changes so that a reviewer can reproduce the results. -->
+<!--- Include details of your testing environment, and the tests you've run your self -->
+<!--- see how your change affects other areas of the code, etc. -->
+
+### How Will This Be Deployed?
+
+<!--- Run through any change to infrastructure, CLI commands or manual admin config to do -->
+<!--- For example, any env variables to add to the hosting infra? -->
+
+### Screenshots
+
+<!--Optional. Delete if not relevant.
+Include screenshots (before / after) for style changes, highlight edited element.-->

From 453f671991dcc3d3ffd32332616652d07ad4d695 Mon Sep 17 00:00:00 2001
From: Leni Kadali <52788034+lenikadali@users.noreply.github.com>
Date: Tue, 22 Oct 2024 22:42:22 +0300
Subject: [PATCH 2/2] Switch to checkbox for deployment, remove tests check

Switched the heading for deployment changes to a checkbox
under the checklist regarding what the effect of the changes
are.

Removed the check for tests since as of now we have test
automation that notifies the committer that their changes
break existing tests.
---
 .github/PULL_REQUEST_TEMPLATE.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index f9e3db5f9..18ee399e7 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -7,7 +7,6 @@
 - [ ] I have commented my code, particularly in hard-to-understand areas,
 - [ ] I have made corresponding changes to the documentation,
 - [ ] I have added tests that prove my fix is effective or that my feature works,
-- [ ] New and existing unit tests pass locally with my changes
 - [ ] Title include "WIP" if work is in progress.
 -->
 
@@ -33,6 +32,7 @@ Include anything else we should know about.-->
 - [ ] Bug fix (non-breaking change which fixes an issue)
 - [ ] New feature (non-breaking change which adds functionality)
 - [ ] Breaking change (fix or feature that would cause existing functionality to change)
+- [ ] This change requires a change to the deployment process
 - [ ] This change requires a documentation update
 - [ ] Documentation update