Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template for PlaceCal #2630

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add pull request template for PlaceCal #2630

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9fd039
Add pull request template
lenikadali Oct 22, 2024
453f671
Switch to checkbox for deployment, remove tests check
lenikadali Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<!--- Provide a general summary of your changes in the Title above -->
<!--Read comments, before committing pull request read checklist again

# Checklist:

- [ ] I have performed a self-review of my own code,
- [ ] I have commented my code, particularly in hard-to-understand areas,
- [ ] I have made corresponding changes to the documentation,
- [ ] I have added tests that prove my fix is effective or that my feature works,
- [ ] New and existing unit tests pass locally with my changes
lenikadali marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Title include "WIP" if work is in progress.
-->

Resolves # <!--fill issue number-->

## Description

<!--- Describe your changes in detail -->

### Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

<!--- If there's a Figma file or similar spec, please link to to the issue. List any dependencies that are required for this change. (gems, js libraries, etc.)

Include anything else we should know about.-->

### Type of change

<!-- Please delete options that are not relevant. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] This change requires a documentation update
- [ ] Documentation update

### How Has This Been Tested?

<!--- Please describe in detail how you tested your changes so that a reviewer can reproduce the results. -->
<!--- Include details of your testing environment, and the tests you've run your self -->
<!--- see how your change affects other areas of the code, etc. -->

### How Will This Be Deployed?
lenikadali marked this conversation as resolved.
Show resolved Hide resolved

<!--- Run through any change to infrastructure, CLI commands or manual admin config to do -->
<!--- For example, any env variables to add to the hosting infra? -->

### Screenshots

<!--Optional. Delete if not relevant.
Include screenshots (before / after) for style changes, highlight edited element.-->
Loading