Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add component guidelines for PlaceCal #2648

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

lenikadali
Copy link
Collaborator

@lenikadali lenikadali commented Nov 26, 2024

Added component guidelines for PlaceCal.

Checklist:

  • I have performed a self-review of my own code,
  • I have commented my code, particularly in hard-to-understand areas,
  • I have made corresponding changes to the documentation,

Resolves #2641
Work towards #2551 (the component guidelines item in the checklist)

Description

Added component guidelines for PlaceCal.
This will allow new contributors easily understand how to interact with components when developing.

Motivation and Context

This is meant to provide clarity on how we structure components in the PlaceCal repository as well as what we expect when new components are added/modified/removed

Relevant issues are #2641 as well as #2638 (the first PR in moving components from mountain_view to view_component) for reading the discussions had there.

Type of change

  • Documentation update

How Has This Been Tested?

By previewing the resulting markdown file.

Huly®: PC-2654

Added component guidelines for PlaceCal. This will allow
new contributors easily understand how to interact with components
when developing.
Copy link
Member

@kimadactyl kimadactyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect 👌

@kimadactyl kimadactyl changed the title chore: Add component guidelines for PlaceCal docs: Add component guidelines for PlaceCal Nov 26, 2024
@kimadactyl kimadactyl enabled auto-merge (squash) November 26, 2024 20:41
@kimadactyl kimadactyl disabled auto-merge November 26, 2024 20:41
@kimadactyl kimadactyl enabled auto-merge (squash) November 26, 2024 20:42
@kimadactyl kimadactyl merged commit c36f165 into main Nov 26, 2024
2 checks passed
@kimadactyl kimadactyl deleted the 2551-add-placecal-component-guidelines branch November 26, 2024 20:44
@kimadactyl
Copy link
Member

confirmed working on staging

Screenshot 2024-12-09 at 14 14 41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agree definition of done for view_component migrations and set up code base for work to begin
2 participants