Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility enhancements overall checklist #333

Open
9 of 26 tasks
ivan-kocienski-gfsc opened this issue Oct 18, 2022 · 6 comments
Open
9 of 26 tasks

Accessibility enhancements overall checklist #333

ivan-kocienski-gfsc opened this issue Oct 18, 2022 · 6 comments
Labels
eee Enormous Extra Effort (I have no idea how or needs breaking down) good first issue Should not need in depth knowledge of code base to complete next up? Thinking we might put in scope soon vv Very Valuable
Milestone

Comments

@ivan-kocienski-gfsc
Copy link
Collaborator

ivan-kocienski-gfsc commented Oct 18, 2022

Plan

  • Consider checklist items, group things that can be tackled together and create a linked issue before working on
  • Some of these items good first issue. Please label as such if you convert to linked issue

Following on from #39

A list of fixes to improve accessibility

About

  • "follow us out there" should be a heading
  • "created by" should be a heading ? (this recommendation came from WAVE)
  • About: "Find out more" string should be in copy (more of a chore)

Join Us

Index

  • maybe "View all events" redundant link (duplicate of top-of-page navigation?)
  • The latest news section is skipped entirely except for the "Read the rest" and "view all news". Maybe a clickable title or a clickable image with alt text?

Partners Index

News Index

  • - All the news links are "Read the rest" (repetition)

Partner Show

  • In contact section- there is an empty link (no href, no text).
  • blank link after get in touch email link and before upcoming event list

News Show

  • Missing alt text on img?

Event Show

404 Page

  • Should be title? "This page could not be found"

Misc

  • Footer: viewPageFooter logo and viewPageFooterCredit missing alt text
@katjam
Copy link
Member

katjam commented Oct 18, 2022

@erbridge can you cross ref these list items with your recent PRs? Then we can convert the rest as we go so we don't double up because I think @ivan-kocienski-gfsc will also be fixing some of these in the next day or 2.

@erbridge erbridge added this to the Public release v1.0 milestone Oct 18, 2022
@erbridge
Copy link
Contributor

Done

@kimadactyl kimadactyl removed this from the Public release v1.0 milestone Oct 24, 2022
@kimadactyl
Copy link
Member

kimadactyl commented Oct 24, 2022

This is too much for public release deadline. Blocking/critical issues only should be made into new tickets and added back into the launch ticket in time for Mon 31st Oct.

@kimadactyl kimadactyl changed the title Accessibility enhancements Accessibility enhancements overall checklist Oct 24, 2022
@katjam katjam added vv Very Valuable eee Enormous Extra Effort (I have no idea how or needs breaking down) next up? Thinking we might put in scope soon labels Aug 12, 2024
@katjam katjam added this to the Backlog milestone Aug 12, 2024
@katjam
Copy link
Member

katjam commented Aug 12, 2024

@studiosquid For this one - just review the outstanding work and if there is any list item that feels important then convert it and add to the bottom of milestone.

Shall we...

  1. add to the bottom of work queue, 2) close as a won't fix, 3) leave open for future niceness but not important now.

@katjam katjam added the good first issue Should not need in depth knowledge of code base to complete label Aug 12, 2024
@studiosquid
Copy link

@katjam sorry I don't really know what is meant by "Convert it and add to bottom of milestone" I'm pretty basic in Github. Do you mean make it a separate ticket?

The one that stood out to me as it's my fault:

Partners index

low contrast warning on Partner title pill (the bit next to the name with the location)

This being inaccessible isn't ideal — can we change the hex value for this colour from 683A65 to 432955 this gives us AA access contrast.

Most of these don't stand out to me as they're code based so I don't know the level of severity — if there's bad practice going on then ideally it would be good to resolve things so rate them a 3

@katjam
Copy link
Member

katjam commented Aug 15, 2024

I'll pop that contrast one in the milestone and leave the rest for picking off later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eee Enormous Extra Effort (I have no idea how or needs breaking down) good first issue Should not need in depth knowledge of code base to complete next up? Thinking we might put in scope soon vv Very Valuable
Projects
None yet
Development

No branches or pull requests

5 participants