Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Layout is cramped for partners with no map #358

Open
erbridge opened this issue Nov 2, 2022 · 3 comments
Open

[Bug]: Layout is cramped for partners with no map #358

erbridge opened this issue Nov 2, 2022 · 3 comments
Labels
bug Something isn't working e Effort (I know how and it's quick) good first issue Should not need in depth knowledge of code base to complete v Valuable

Comments

@erbridge
Copy link
Contributor

erbridge commented Nov 2, 2022

Description

When looking at a partner with no map, there's no padding under the events. Probably the padding is on the map and not the event listing where it probably should be.

Screenshot 2022-11-02 at 13 40 33

Steps to reproduce

  1. Visit the page of a partner without a location
@erbridge erbridge added the bug Something isn't working label Nov 2, 2022
@katjam katjam added v Valuable ee Extra Effort (I know how but not trivial) labels Aug 12, 2024
@katjam katjam added this to the Backlog milestone Aug 12, 2024
@katjam
Copy link
Member

katjam commented Aug 12, 2024

@studiosquid

Shall we...

  1. add to the bottom of work queue, 2) close as a won't fix, 3) leave open for future niceness but not important now.

@katjam katjam added the good first issue Should not need in depth knowledge of code base to complete label Aug 12, 2024
@studiosquid
Copy link

studiosquid commented Aug 12, 2024

@katjam
1 — if it's a quick fix it's the sort of thing that should have been caught in the first pass.
3 — if there's no capacity, it really should be fixed though

@katjam katjam added e Effort (I know how and it's quick) and removed ee Extra Effort (I know how but not trivial) labels Aug 12, 2024
@katjam
Copy link
Member

katjam commented Aug 12, 2024

Changing to a single e and promoting to cycle as such. If it turns out not to be a good first issue, we can push to backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e Effort (I know how and it's quick) good first issue Should not need in depth knowledge of code base to complete v Valuable
Projects
None yet
Development

No branches or pull requests

3 participants