Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UTC time is not correct for UK during BST #448

Open
katjam opened this issue Oct 14, 2024 · 3 comments
Open

[Bug]: UTC time is not correct for UK during BST #448

katjam opened this issue Oct 14, 2024 · 3 comments
Labels
bug Something isn't working eee Enormous Extra Effort (I have no idea how or needs breaking down) vvv Very Very Valuable

Comments

@katjam
Copy link
Member

katjam commented Oct 14, 2024

Description

Events in The Trans Dimension calculate their time by converting ISO8601 string to UTC this is incorrect for some of the year

image

See https://www.gov.uk/when-do-the-clocks-change for ref on how to figure out whether we are in summertime

@kimadactyl
Copy link
Member

kimadactyl commented Oct 24, 2024

Do we know if this is a PlaceCal issue or a TransDim one? I think we need to make sure the two projects tickets for this issue are properly separated out as it's a bit confusing to parse atm.

@katjam
Copy link
Member Author

katjam commented Oct 24, 2024

I think we decided this was a Trans Dim only issue. It's because Trans Dim explicitly uses timezone to make the dates from the ISO string and PlaceCal just uses the ISO string. I think

@kimadactyl
Copy link
Member

kimadactyl commented Oct 24, 2024

I think we decided this was a Trans Dim only issue. It's because Trans Dim explicitly uses timezone to make the dates from the ISO string and PlaceCal just uses the ISO string. I think

to narrow it down i think we should be comparing what's coming in through the graphql endpoint to whats displayed on the trans dimension - the other ticket needs updating to to only show the bug as it appears on placecal + the endpoint

@kimadactyl kimadactyl added eee Enormous Extra Effort (I have no idea how or needs breaking down) vvv Very Very Valuable labels Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working eee Enormous Extra Effort (I have no idea how or needs breaking down) vvv Very Very Valuable
Projects
None yet
Development

No branches or pull requests

2 participants