Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Filter news by site partners #456

Open
katjam opened this issue Nov 2, 2024 · 2 comments
Open

[Bug]: Filter news by site partners #456

katjam opened this issue Nov 2, 2024 · 2 comments
Labels
bug Something isn't working good first issue Should not need in depth knowledge of code base to complete v Valuable

Comments

@katjam
Copy link
Member

katjam commented Nov 2, 2024

Description

Currently we do include the partner in News data but I don't think we filter out News Items that belong to partners outside the partnership.

This can be handled in src/Data/Placecal/Articles.elm because we have access to the partner list here.

@katjam katjam added the bug Something isn't working label Nov 2, 2024
@katjam katjam added the good first issue Should not need in depth knowledge of code base to complete label Nov 2, 2024
@katjam katjam mentioned this issue Nov 2, 2024
11 tasks
@kimadactyl
Copy link
Member

kimadactyl commented Nov 11, 2024

I think its OK to just show everything for now? Obviously nice to have the filter option but it doesn't feel high priority to me.

@kimadactyl kimadactyl added the v Valuable label Nov 11, 2024
@katjam
Copy link
Member Author

katjam commented Nov 12, 2024

Agree. It will only be a problem if people start using it. I think the name resolution from the Partners authoring the story won't work if the partners are not included in partnership tags for Trans Dimension but probably will not be noticeable because "I think" they will show as an ID number. We might want to check this though, in case it breaks more dramatically than that.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Should not need in depth knowledge of code base to complete v Valuable
Projects
None yet
Development

No branches or pull requests

2 participants