Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Partner event listings are showing inconsistent interface and date browsers #473

Closed
kimadactyl opened this issue Dec 8, 2024 — with Huly for GitHub · 5 comments · Fixed by #475
Closed
Assignees
Labels
bug Something isn't working vvv Very Very Valuable

Comments

Copy link
Member

kimadactyl commented Dec 8, 2024

Description

Looking at individual partners, the events browsers are in some cases showing a full day browser (whcih is way overkill) or in some cases indicating a day has been selected when it's not.

These should just list all future events instead. Assume this got a bit scrambled when the changeover happened.

Screenshot 2024-12-08 at 14 14 23 Screenshot 2024-12-08 at 14 15 23

Steps to reproduce

  1. Visit https://transdimension.uk/partners/303
  2. Visit https://transdimension.uk/partners/150

Huly®: TD-474

@kimadactyl kimadactyl added the bug Something isn't working label Dec 8, 2024
@kimadactyl kimadactyl added the vvv Very Very Valuable label Dec 8, 2024
@katjam
Copy link
Member

katjam commented Dec 8, 2024

#206 some of the view events logic was lost when adding the region filter

@katjam katjam self-assigned this Dec 10, 2024
@katjam
Copy link
Member

katjam commented Dec 10, 2024

I'll remove the filter altogether. We can add back past events if that seems important.

@kimadactyl
Copy link
Member Author

yeah i think just showing future events is great for now, a past button would be a nice extra but for another day :)

@katjam
Copy link
Member

katjam commented Dec 10, 2024

Actually, looking at the code, it's just that the logic for checking event numbers is happening before the filter is applied. So the path of least change might be to make sure the events are filtered for future before the branching. Previously the list was filtered before being passed to the component.

@katjam
Copy link
Member

katjam commented Dec 10, 2024

yeah i think just showing future events is great for now, a past button would be a nice extra but for another day :)

Cool - I'll see which fix is less changes. Now that I've seen what is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vvv Very Very Valuable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants