SDGF-151: add versions to javadoc header (#29)

* SDGF-151: add versions to javadoc header * SDGF-151: Address feedback
gemfire · Oct 13, 2023 · c963262 · c963262
1 parent 866ef0e
commit c963262
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/...onstraints/src/main/groovy/com/vmware/gemfire/gradle/plugins/DependencyConstraints.groovy b/...onstraints/src/main/groovy/com/vmware/gemfire/gradle/plugins/DependencyConstraints.groovy
@@ -39,7 +39,6 @@ class DependencyConstraints {
     depVersionMapping.put("springVersion","5.3.30")
     depVersionMapping.put("springBootVersion","2.7.13")
     depVersionMapping.put("springDataCommonsVersion","2.7.16")
-    depVersionMapping.put("springSessionVersion","2.7.3")
     depVersionMapping.put("multithreadedtcVersion","1.01")
     depVersionMapping.put("apacheLogging","2.14.1")
     depVersionMapping.put("jsr305Version","3.0.2")
@@ -74,7 +73,6 @@ class DependencyConstraints {
         api(group: 'org.springframework.security', name: 'spring-security-test', version: get('springSecurityVersion'))
         api(group: 'org.springframework.security', name: 'spring-security-web', version: get('springSecurityVersion'))
         api(group: 'org.springframework.security', name: 'spring-security-core', version: get('springSecurityVersion'))
-        api(group: 'org.springframework.session', name: 'spring-session-core', version: get('springSessionVersion'))
         api(group: 'org.springframework.shell', name: 'spring-shell', version: get('springShellVersion'))
         api(group: 'org.webjars', name: 'bootstrap', version: '2.3.2')
         api(group: 'org.webjars', name: 'jquery', version: '1.12.4')

diff --git a/gradle.properties b/gradle.properties
@@ -7,6 +7,7 @@ springDataGemFireVersion=1.0.1
 version=1.0.1-build.9999
 gemfireVersion=10.0.1
 springDataBaseVersion=SD27
+springSessionVersion=2.7.3
 springTestGemFireVersion=1.0.1
 
 additionalMavenRepoURLs=''

diff --git a/spring-session-data-gemfire/build.gradle b/spring-session-data-gemfire/build.gradle
@@ -19,7 +19,7 @@ java {
 }
 
 javadoc {
-  title = "Spring Session for VMware GemFire Java API Reference"
+  title = "Spring Session ${getSpringSessionBaseVersion()} for VMware GemFire ${getGemFireBaseVersion()} Java API Reference"
   failOnError=false
 }
 
@@ -35,7 +35,7 @@ dependencies {
   implementation "javax.annotation:javax.annotation-api:1.3.2"
 
   api "com.vmware.gemfire:spring-data-2.7-gemfire-${getGemFireBaseVersion()}:${springDataGemFireVersion}"
-  api 'org.springframework.session:spring-session-core:2.7.1'
+  api "org.springframework.session:spring-session-core:$springSessionVersion"
 
 
   implementation 'com.google.code.findbugs:jsr305'
@@ -134,9 +134,17 @@ repositories {
 }
 
 String getGemFireBaseVersion() {
-  def split = "${gemfireVersion}".split("\\.")
+  return getBaseVersion(gemfireVersion)
+}
+
+String getSpringSessionBaseVersion() {
+  return getBaseVersion(springSessionVersion)
+}
+
+static String getBaseVersion(String version) {
+  def split = "${version}".split("\\.")
   if (split.length < 2) {
-    throw new RuntimeException("gemfireVersion is malformed")
+    throw new RuntimeException("version '$version' is malformed")
   }
   return "${split[0]}.${split[1]}"
 }