Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes to panther/enrichment docs #12

Open
cmungall opened this issue Mar 13, 2019 · 3 comments
Open

Proposed changes to panther/enrichment docs #12

cmungall opened this issue Mar 13, 2019 · 3 comments
Assignees

Comments

@cmungall
Copy link
Member

These comments pertain to the panther site not GO, but the user ends up here when they do an enrichment so I think it's important to make some clarification from a GO point of view

"Please refer to our article in Nature Protocols for detailed instructions on how to use this page"

When I link to the nature protocols paper outside my institution network I get "Subscribe to Journal for $495.00"

I think the documentation should be on the site rather than in a closed-source article

http://www.pantherdb.org/about.jsp

  • UPL14.0 New! PANTHER14.0 is generated from the 2018_04 release of ReferenceProteome dataset
  • Version 14.0 (released 2018-12-03) contains 15512 protein families, divided into 104496 functionally distinct protein subfamilies.

This doesn't mention the version of GO used (although you do get this when you do an enrichment analysis)

http://www.pantherdb.org/panther/ontologies.jsp

The PANTHER Protein Class ontology was adapted from the PANTHER/X molecular function ontology, and includes commonly used classes of protein functions, many of which are not covered by GO molecular function

It would be useful to see more on why they are not covered. Is it a scope issue or a deficiency in GO (the way it is worded sounds like the latter)

There is a link to the panther ontology http://data.pantherdb.org/PANTHER14.0/ontology/Protein_Class_14.0 but there are no mappings to GO

"PANTHER uses only a subset of GO terms (“GO slim”) to facilitate browsing. Download the PANTHER GO slim."
http://data.pantherdb.org/PANTHER14.0/ontology/PANTHERGOslim.obo

But it's not clear what the use case is for this, or any version info (looks like this is from mid-2018?). A user may think that this is the subset used for enrichment analysis in GO.

@ValWood
Copy link

ValWood commented Mar 13, 2019

Should also be made clear in the docs (or preferably up front) that the panther enrichment tool does not include regulates relationship. This negatively affects enrichment results (many regulation annotations are within pathway, or direct upstream signalling and you need the "regulation of" terms to see these in enrichments

@huaiyumi
Copy link

The Nature Protocol paper has been uploaded to the PMC, and should be freely available soon.
The About page in PANTHER is an overview of the gene families. The details about the data, including GO version and GO-slim version can be found at http://www.pantherdb.org/data/. Also, since we update GO on monthly base, its version is described on each test page.
Protein Class is not mapped to GO. It has commonly used terms such as zinc finger transcription factor or cytoskeletal protein, which are not in GO.

@huaiyumi
Copy link

We have updated the followings:

  1. Updates to Help Tips on the landing page.
  2. Updates to counts on About page
  3. Updated from "annotation" to "terms" for Full GO description in the PANTHER data page.
  4. Added page with description about PANTHER GO-slim
    Please double check and see if this is sufficient, and close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants