Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prop decorator cannot set function/class as property #55

Open
unlight opened this issue Nov 8, 2019 · 1 comment
Open

Prop decorator cannot set function/class as property #55

unlight opened this issue Nov 8, 2019 · 1 comment
Assignees
@geocine

Comments

@unlight
Copy link

unlight commented Nov 8, 2019

Prop decorator set function is checking only for typeof value != 'object', which is not enough, there is another non primitive type - function
@geocine
Copy link
Owner

geocine commented Nov 15, 2019

right I think I should change it altogether since I only expect a string and an object to be precise

@geocine geocine self-assigned this Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geocine geocine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unlight @geocine