Skip to content
This repository has been archived by the owner on Jan 23, 2020. It is now read-only.

MD style for buttons #5

Open
JosefJezek opened this issue Jul 19, 2017 · 5 comments
Open

MD style for buttons #5

JosefJezek opened this issue Jul 19, 2017 · 5 comments
Labels
enhancement
Milestone
1.1.0

Comments

@JosefJezek
Copy link
Contributor

JosefJezek commented Jul 19, 2017 •
edited
Loading

Button has bad padding, height and line-height, use px.

image

https://github.com/material-components/material-components-web/blob/master/packages/mdc-button/mdc-button.scss#L26
@ianschmitz
Copy link
Contributor

We consciously made the decision to use em's for sizing if that is what you are referring to. Is there a specific problem you have observed?

@JosefJezek
Copy link
Contributor Author

px's are better for pixel perfect design. MD specification define size in px. On top image is button GOT IT with bad vertical align text due em.

@JosefJezek
Copy link
Contributor Author

https://material.io/guidelines/components/buttons.html#buttons-style

@JosefJezek
Copy link
Contributor Author

Please same style for skip button. MD has consistent style for buttons in dialog.

@ianschmitz ianschmitz mentioned this issue Jul 23, 2017
Open
@ianschmitz
Copy link
Contributor

Thanks for the information. #8 should take care of it.

@ianschmitz ianschmitz self-assigned this Jul 23, 2017
@ianschmitz ianschmitz modified the milestone: 1.1.0 Jul 23, 2017
@ianschmitz ianschmitz removed their assignment Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@JosefJezek @ianschmitz