Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update process may spam #9

Open
ron-popov opened this issue Nov 2, 2017 · 3 comments
Open

Update process may spam #9

ron-popov opened this issue Nov 2, 2017 · 3 comments
Assignees
Labels

Comments

@ron-popov
Copy link
Member

ron-popov commented Nov 2, 2017

When updating itself sometimes there will be a couple of popup messages and it seems like the program is fetching the data and commit hashes a couple of times.

Edit : The source of this problem is the waitForJqeury function. For some reason it doesn't stop checking if jquery is loaded after it called the callback method.

@ron-popov ron-popov self-assigned this Nov 2, 2017
@ron-popov ron-popov added the Bug label Nov 2, 2017
@ron-popov ron-popov changed the title Stuck in infinite loop Update process may spam Nov 2, 2017
ron-popov added a commit that referenced this issue Nov 2, 2017
@ron-popov
Copy link
Member Author

Fixed in commit 8426162.
Fixed it by calling clearTimeout() before calling the callback method of waitForJquery.
I think that this interfere with any timeouts created before this method so we should take this into considiration.

@ron-popov
Copy link
Member Author

Never mind, the problem is that even after jquery is loaded and the callback method is called, waitForJquery still checks if jquery is loaded and calls the callback method again.

@ron-popov ron-popov reopened this Nov 6, 2017
@ron-popov
Copy link
Member Author

ron-popov commented Nov 10, 2017

9e1236f Might fix it

Edit : it does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant