Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lerna-lite & npm workspaces #78

Merged
merged 10 commits into from
Dec 19, 2023
Merged

Add lerna-lite & npm workspaces #78

merged 10 commits into from
Dec 19, 2023

Conversation

phanect
Copy link
Contributor

@phanect phanect commented Dec 6, 2023

本リポジトリーにパッケージを追加する予定があるため、先立って lerna-lite と npm workspaces を導入し、monorepo 化する。
また、本修正の過程で、コンポーネントとして本パッケージを利用する場合は、CSS ファイルを別途 import する必要があることが判明したため、CSS ファイルを import で呼び出せるように修正し、(6941491) ドキュメントも修正した。(07facaf)

GitHub Actions による GitHub Pages へのデプロイは、フォークした個人リポジトリー上でテスト済み: https://phanect.github.io/opendata-editor/?data=https://opendata.takamatsu-fact.com/kindergarten/data.csv#9.97/34.2872/134.0526

@phanect phanect self-assigned this Dec 6, 2023
Copy link

cloudflare-workers-and-pages bot commented Dec 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 203bf83
Status: ✅  Deploy successful!
Preview URL: https://05b303f6.opendata-editor-preview.pages.dev
Branch Preview URL: https://refactor-monorepo.opendata-editor-preview.pages.dev

View logs

@phanect phanect changed the title lerna-lite の導入による monorepo 化 Add lerna-lite & npm workspaces Dec 6, 2023
@phanect phanect linked an issue Dec 18, 2023 that may be closed by this pull request
Copy link
Member

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューが遅くなって申し訳ありません、、良さそうです。ありがとうございます!!

@phanect phanect merged commit 32842df into main Dec 19, 2023
4 checks passed
@phanect phanect deleted the refactor-monorepo branch December 19, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

セルフホストしやすくする
2 participants