-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lerna-lite & npm workspaces #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
phanect
force-pushed
the
refactor-monorepo
branch
from
December 6, 2023 07:48
ee16279
to
97b457f
Compare
phanect
force-pushed
the
refactor-monorepo
branch
from
December 6, 2023 07:56
97b457f
to
203bf83
Compare
Open
keichan34
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビューが遅くなって申し訳ありません、、良さそうです。ありがとうございます!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本リポジトリーにパッケージを追加する予定があるため、先立って lerna-lite と npm workspaces を導入し、monorepo 化する。
また、本修正の過程で、コンポーネントとして本パッケージを利用する場合は、CSS ファイルを別途
import
する必要があることが判明したため、CSS ファイルをimport
で呼び出せるように修正し、(6941491) ドキュメントも修正した。(07facaf)GitHub Actions による GitHub Pages へのデプロイは、フォークした個人リポジトリー上でテスト済み: https://phanect.github.io/opendata-editor/?data=https://opendata.takamatsu-fact.com/kindergarten/data.csv#9.97/34.2872/134.0526