Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SASS Mixins for Icons #21

Open
voidstate opened this issue Mar 21, 2017 · 5 comments
Open

Create SASS Mixins for Icons #21

voidstate opened this issue Mar 21, 2017 · 5 comments

Comments

@voidstate
Copy link
Contributor

Hi Guys

I'm thinking of using this repo for the icons in my app but it seems to be written to only support declarative usage. I'd prefer to use the icons directly in my own SASS files.

Would you be open to me refactoring the SASS file to use mixins so you can call them directly in another SASS file, or output a CSS file exactly the same as the current one.

It'd be based roughly on (a simpler version of) this: http://jaydenseric.com/blog/fun-with-sass-and-font-icons

Alternatively, if you have a better idea for how to do this, I'd be glad to hear it.

@geordanr
Copy link
Owner

That sounds good to me.

@voidstate
Copy link
Contributor Author

Thanks, Geordan. I'll see what I can do...

@voidstate
Copy link
Contributor Author

Done.

The output CSS file looks the same to me.

I'm new to Grunt so you might want to check my Gruntfile. And I used SCSS instead of SASS - does that matter? I was having trouble writing the mixin in SASS mode. :/

#22

@voidstate
Copy link
Contributor Author

Do you want me to write a short how to guide for using the SASS files for inclusion in the readme?

@Hinny
Copy link
Collaborator

Hinny commented Mar 23, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants