Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical debt issues #106

Open
3 of 16 tasks
niharikasingh opened this issue Sep 2, 2022 · 0 comments
Open
3 of 16 tasks

Technical debt issues #106

niharikasingh opened this issue Sep 2, 2022 · 0 comments

Comments

@niharikasingh
Copy link
Contributor

niharikasingh commented Sep 2, 2022

This is a list of issues that is not blocking release of v1, but would be nice to do someday to make the codebase cleaner.

  • Use constants for "materials", "tools"
  • Use constants for "binary", "gradient"
  • In dashboard.js, the useEffect and handleChange functions have some code duplication that could be refactored
  • As currently written, I believe sub-sub-inputs will be broken. We don't need this functionality yet though.
  • Move styles from jsx to scss files (as much as possible)
  • Import svgs from an svg file instead of putting the entire svg in the shared.js file
  • The graph node has duplication in how it constructs the input nodes. Refactor.
  • The documentation node has duplication in how it constructs the sidebar. Refactor.
  • Should mk_provider_to_meta use the get_country function?
  • Remove flags from orgProvision and use flags from the countryFlags dict in the frontend
  • Python strings to constants
  • Add tests for countryFlags function in preprocessing script
  • Add ESlint to precommit
  • Refactor getBackgroundGradient function to also return unhighlighted
  • Documentation node gets params node and currSelectedNode which seem duplicative
  • Refactor InputDetail so that the variant and non-variant country and org tables are constructed similarly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants