Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Reset filters' should also reset groups #38

Closed
brianlove opened this issue Aug 4, 2023 · 2 comments · Fixed by #44
Closed

'Reset filters' should also reset groups #38

brianlove opened this issue Aug 4, 2023 · 2 comments · Fixed by #44
Assignees
Milestone

Comments

@brianlove
Copy link
Contributor

From #35 (review):

  1. When only the group is selected, clicking "reset filters" does not undo the group selection.

Should 'Reset filters' also reset groups, or would users expect the two elements to be distinct?

@za158
Copy link
Member

za158 commented Aug 4, 2023 via email

@brianlove brianlove changed the title Should 'Reset filters' also reset the group selection? 'Reset filters' should also reset groups Aug 4, 2023
@brianlove brianlove added this to the PARAT v2 milestone Aug 4, 2023
@brianlove brianlove assigned brianlove and unassigned jmelot and za158 Aug 4, 2023
brianlove added a commit that referenced this issue Aug 15, 2023
brianlove added a commit that referenced this issue Aug 15, 2023
@brianlove brianlove linked a pull request Aug 21, 2023 that will close this issue
@brianlove
Copy link
Contributor Author

Closed by #44

jmelot pushed a commit that referenced this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants