fix typing

Author: georghess

Dockerfile

@@ -141,6 +141,9 @@ RUN git clone --recursive https://github.com/cvg/pixel-perfect-sfm.git && \
 # Install waymo-open-dataset
 RUN python3.10 -m pip install --no-cache-dir waymo-open-dataset-tf-2-11-0==1.6.1
 
+# Install tzdata
+RUN python3.10 -m pip install --no-cache-dir tzdata
+
 # Copy nerfstudio folder.
 ADD . /nerfstudio
 

nerfstudio/cameras/camera_optimizers.py

@@ -47,7 +47,7 @@ class CameraOptimizerConfig(InstantiateConfig):
     mode: Literal["off", "SO3xR3", "SE3"] = "off"
     """Pose optimization strategy to use. If enabled, we recommend SO3xR3."""
 
-    trans_l2_penalty: float = 1e-2
+    trans_l2_penalty: Union[Tuple, float] = 1e-2
     """L2 penalty on translation parameters."""
 
     rot_l2_penalty: float = 1e-3
@@ -206,9 +206,20 @@ class ScaledCameraOptimizerConfig(CameraOptimizerConfig):
 
     _target: Type = field(default_factory=lambda: ScaledCameraOptimizer)
 
-    weights: Tuple[float, float, float, float, float, float] = (1.0, 1.0, 1.0, 1.0, 1.0, 1.0)
-
-    trans_l2_penalty: Tuple[float, float, float] = (1e-2, 1e-2, 1e-2)  # TODO: this is l1
+    weights: Tuple[float, float, float, float, float, float] = (
+        1.0,
+        1.0,
+        1.0,
+        1.0,
+        1.0,
+        1.0,
+    )
+
+    trans_l2_penalty: Union[Tuple[float, float, float], float] = (
+        1e-2,
+        1e-2,
+        1e-2,
+    )  # TODO: this is l1
 
 
 class ScaledCameraOptimizer(CameraOptimizer):

nerfstudio/configs/method_configs.py

@@ -360,7 +360,11 @@
 method_configs["neurad-scaleopt"].method_name = "neurad-scaleopt"
 method_configs["neurad-scaleopt"].pipeline.model.camera_optimizer = ScaledCameraOptimizerConfig(
     weights=(1.0, 1.0, 0.01, 0.01, 0.01, 1.0),  # xrot, yrot, zrot, xtrans, ytrans, ztrans
-    trans_l2_penalty=(1e-2, 1e-2, 1e-3),  # x, y, z
+    trans_l2_penalty=(
+        1e-2,
+        1e-2,
+        1e-3,
+    ),  # x, y, z
     mode="SO3xR3",
 )
 
@@ -397,7 +401,11 @@ def _scaled_neurad_training(config: TrainerConfig, scale: float, newname: str) -
 method_configs["neurader-scaleopt"].method_name = "neurader-scaleopt"
 method_configs["neurader-scaleopt"].pipeline.model.camera_optimizer = ScaledCameraOptimizerConfig(
     weights=(1.0, 1.0, 0.01, 0.01, 0.01, 1.0),  # xrot, yrot, -zrot-, -xtrans-, -ytrans-, ztrans
-    trans_l2_penalty=(1e-2, 1e-2, 1e-3),  # x, y, z
+    trans_l2_penalty=(
+        1e-2,
+        1e-2,
+        1e-3,
+    ),  # x, y, z
     mode="SO3xR3",
 )
 
@@ -463,4 +471,4 @@ def sort_methods(methods, method_descriptions):
 ]
 """Union[] type over config types, annotated with default instances for use with
 tyro.cli(). Allows the user to pick between one of several base configurations, and
-then override values in it."""
+then override values in it."""