Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly comparing floats causes random test failings #666

Closed
martinfrances107 opened this issue Oct 13, 2021 · 3 comments
Closed

Incorrectly comparing floats causes random test failings #666

martinfrances107 opened this issue Oct 13, 2021 · 3 comments

Comments

@martinfrances107
Copy link
Contributor

We are experiencing random test failings random fail

we developed a solution #565

The solution is to consistently apply our unspoken policy of use assert_relative_eq!() where possible.

I am working on a PR.
@martinfrances107 martinfrances107 mentioned this issue Oct 13, 2021
Merged
1 task
@martinfrances107
Copy link
Contributor Author

martinfrances107 commented Oct 13, 2021 •
edited
Loading

#667

This PR is a scan of the map_coords.rs files.. picking up all the problem comparisions that I could see.

@michaelkirk
Copy link
Member

Fixed in #667

@lnicola
Copy link
Member

lnicola commented Oct 13, 2021

I think there are other places where this is done, so I'm not sure it's fully fixed.

@michaelkirk michaelkirk reopened this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelkirk @lnicola @martinfrances107