Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate EuclideanDistance #1232

Merged
merged 4 commits into from
Oct 25, 2024
Merged

deprecate EuclideanDistance #1232

merged 4 commits into from
Oct 25, 2024

Commits on Oct 22, 2024

  1. Move all geometries impls into impl Distance for Euclidean 

    As part of aligning all our line measure traits (see
#1181), all the Point x Point
distance calculations had been moved into `line_measures::metric_spaces`.

Euclidean space is the only space that implements distance calculations
on *non* point geometries. This commit moves all those calculations onto
the `line_measures::metric_spaces::Euclidean` so that we can fully
deprecate the existing EuclideanDistance trait.
    @michaelkirk
    michaelkirk committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4b95247 View commit details
    Browse the repository at this point in the history

  2. consolidate some macro usage

    @michaelkirk
    michaelkirk committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7cf0d6a View commit details
    Browse the repository at this point in the history

  3. changelog

    @michaelkirk
    michaelkirk committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    06c484d View commit details
    Browse the repository at this point in the history

  4. fixup! Move all geometries impls into impl Distance for Euclidean

    @michaelkirk
    michaelkirk committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0e9c0a4 View commit details
    Browse the repository at this point in the history