Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review how map config is generated at store level #10667

Open
4 tasks
MV88 opened this issue Nov 12, 2024 · 0 comments
Open
4 tasks

Review how map config is generated at store level #10667

MV88 opened this issue Nov 12, 2024 · 0 comments
Assignees

Comments

@MV88
Copy link
Contributor

MV88 commented Nov 12, 2024

Description

There is an historical implementation of how layers are managed and added to the application.
This way of updating map config state prevents easy way of overriding the state entering the loop of side effects that can not cover all possible cases
This might imply a breaking change as it is changing the way the core updates mapconfig state

See below possible options to explore / do

Acceptance criteria

  • Here https://github.com/geosolutions-it/MapStore2/blob/master/web/client/stores/defaultOptions.js#L62 we split map and layers and then we add them to the application state
  • mapConfig reducer is wrapped with splitMapAndLayers and this might go inside the reducer logic
  • Alternatively we should check if it possible to apply changes to actions payload before they are sent to the reducer. like with an override at webpack level from a standard mapstore project
  • if splitMapAndLayers was needed for createHistory, wouldnt' be possible to remove the history feature or implement it differently without impacting store this way?

Other useful information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants