Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review pluginsConfig after introduction of new homepage plugins #10781

Closed
1 task done
allyoucanmap opened this issue Jan 27, 2025 · 6 comments · Fixed by #10800 or geosolutions-it/geostore#417
Closed
1 task done

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Jan 27, 2025

Description

From #10731 (review):

PluginsConfig should be updated with new plugins, to compose context with new plugins and settings.

We should evaluate which plugin and how should be configured inside a context, at the moment the contexts have the same plugins as before. Probably the BrandNavbar and ResourceDetails plugins should be included.

We should also decide if plugin like the BrandNavbar is configured at app level (localConfig.json) or at context level (pluginsConfigjson)

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features

Other useful information

@ElenaGallo
Copy link
Contributor

@allyoucanmap If the Resource Details and/or Brand Navbar and/or Save plugins are not enabled, the context cannot be displayed and the following error appears:

Image

@tdipisa tdipisa reopened this Feb 25, 2025
@allyoucanmap
Copy link
Contributor Author

@ElenaGallo (cc @tdipisa) I checked but I'm not able to replicate the problem, the server returns a 500 error for the specific context in the GIF ( eg. ContextUI ). I've created a similar context named ContextUI2 on dev and I'm able to open it. Could you please double check if with other contexts there is a similar error? thanks

@ElenaGallo
Copy link
Contributor

@allyoucanmap You are right because the problem occurs when a context is added to favorites, regardless of the plugins that have been enabled on it.

@allyoucanmap
Copy link
Contributor Author

@tdipisa to reproduce the problem you need to:

  • create a resource with CONTEXT category and a name (eg. name MyContext)
  • the resource must have favorite true for the current user
  • request the resource with /rest/geostore/misc/category/name/CONTEXT/resource/name/MyContext

The endpoint should be /rest/geostore/misc/category/name/{category}/resource/name/{name}

@tdipisa
Copy link
Member

tdipisa commented Feb 25, 2025

@tdipisa to reproduce the problem you need to:

  • create a resource with CONTEXT category and a name (eg. name MyContext)
  • the resource must have favorite true for the current user
  • request the resource with /rest/geostore/misc/category/name/CONTEXT/resource/name/MyContext

The endpoint should be /rest/geostore/misc/category/name/{category}/resource/name/{name}

@axl8713 we need you to have a quick look at the backend part for this.

@axl8713
Copy link

axl8713 commented Feb 26, 2025

@tdipisa to reproduce the problem you need to:

  • create a resource with CONTEXT category and a name (eg. name MyContext)
  • the resource must have favorite true for the current user
  • request the resource with /rest/geostore/misc/category/name/CONTEXT/resource/name/MyContext

The endpoint should be /rest/geostore/misc/category/name/{category}/resource/name/{name}

@axl8713 we need you to have a quick look at the backend part for this.

PR for the fix here: geosolutions-it/geostore#417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment