Writing compressed tiled TIFF is broken since 1.4.8

[nlinside]

Writing compressed tiled TIFF is broken since 1.4.8. Here's why :

From TIFFImageWriter :

        // Write the image, a strip or tile at a time
        for (int tj = 0; tj < tilesDown; tj++) {
            for (int ti = 0; ti < tilesAcross; ti++) {
                long pos = stream.getStreamPosition();

                // Write the (possibly compressed) tile data

                Rectangle tileRect =
                    new Rectangle(sourceXOffset + ti*tileWidth*periodX,
                                  sourceYOffset + tj*tileLength*periodY,
                                  tileWidth*periodX,
                                  tileLength*periodY);
                // tileRect = tileRect.intersection(imageBounds); // XXX

                try {
                    int byteCount = writeTile(tileRect, compressor);

...

    private int writeTile(Rectangle tileRect, TIFFCompressor compressor)
        throws IOException {
...
                return compressor.encode(buf, 0,
                                         width, height, sampleSize,
                                         (tileRect.width + 7)/8);

From TIFFDeflater (used as the TIFFCompressor):

    public int encode(byte[] b, int off,
                      int width, int height,
                      int[] bitsPerSample,
                      int scanlineStride) throws IOException {
...
         // Previously on 1.4.7, "deflateCompressor.done()" was called, calling Deflater::reset()
         //   deflateCompressor.done();
        // Since 1.48, deflater is not reseted !!.
       // Be careful, deflateCompressor.done() doesn't call Deflater::reset() now !!

Problematic changes :

[aaime]

Write a test that fails, and then write a fix, and then make a PR. We'll review and make sure to include in the next release (there is no schedule for it, but the fix will be in when it happens).

[nlinside]

@aaime Done.