Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Travis CI osx builds will fall due to known upstream issue. #242

Closed
2 of 3 tasks
bokov opened this issue Oct 14, 2019 · 5 comments · Fixed by #247
Closed
2 of 3 tasks

All Travis CI osx builds will fall due to known upstream issue. #242

bokov opened this issue Oct 14, 2019 · 5 comments · Fixed by #247
Labels
Milestone

Comments

@bokov
Copy link
Contributor

bokov commented Oct 14, 2019

The data.table team has closed the following ticket with a workaround for an issue someone else reported that seems to be the same as the one we are having:

Rdatatable/data.table#3938 (comment)

Please specify whether your issue is about:

  • a possible bug
  • a question about package functionality
  • a suggested code or documentation change, improvement to the code, or feature request

If you are reporting (1) a bug or (2) a question about code, please supply:

  • a fully reproducible example using a publicly available dataset (or provide your data)
  • if an error is occurring, include the output of traceback() run immediately after the error occurs
  • the output of sessionInfo()

Put your code here:

## load package
library("rio")

## code goes here


## session info for your system
sessionInfo()
@bokov
Copy link
Contributor Author

bokov commented Oct 14, 2019

Made bugfix branch implementing their change to .travis.yml and pushed it to my fork. In a few hours we'll see if it fixes the osx data.table error. If it does, I will submit a PR.

@bokov
Copy link
Contributor Author

bokov commented Oct 14, 2019

Travis CI again works for MacOSX!! The developer versions of R still failing for Appveyor. I think maybe Appveyor is not finding the binary versions of 22 packages that rio depends on or suggests.

No idea so far what to do about Appveyor, but here's a PR for Travis-CI.

@bokov
Copy link
Contributor Author

bokov commented Oct 17, 2019

Here is the build that's working on Mac again:

https://travis-ci.org/bokov/rio/builds/597576597

@leeper leeper added the bug label Oct 19, 2019
@bokov
Copy link
Contributor Author

bokov commented Oct 28, 2019

Closed by #243 , thanks!

@bokov bokov closed this as completed Oct 28, 2019
@bokov bokov reopened this Nov 4, 2019
@bokov
Copy link
Contributor Author

bokov commented Nov 4, 2019

I am reopening this issue because apparently the pre-built Mac binary for data.table is now available, and builds will go faster without having to install LLVM and compile data.table.

I undid my changes from #243 in my fork, and that problem no longer happens in the builds (a different one does, unrelated and possibly at the Travis CI end, I will submit a separate ticket for that one).

Do you prefer to roll back PR #243, for me to submit a new PR undoing the previous one, to leave it as-is, or something else?

bokov added a commit to bokov/rio that referenced this issue Nov 8, 2019
…e8.3 setting, letting the current default (and newer) version of xcode be used instead. Also took the before_install script back out because now the data.table binary is again available. Fixes gesistsa#246. Fixes gesistsa#242
leeper pushed a commit that referenced this issue Dec 17, 2019
…e8.3 setting, letting the current default (and newer) version of xcode be used instead. Also took the before_install script back out because now the data.table binary is again available. Fixes #246. Fixes #242
@leeper leeper added this to the v0.6 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants