Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 point unicity in validity check #54

Merged
merged 1 commit into from
Apr 4, 2024
Merged

🐛 point unicity in validity check #54

merged 1 commit into from
Apr 4, 2024

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Apr 4, 2024

Issue discovered by @stevieraykatz here

@qd-qd qd-qd self-assigned this Apr 4, 2024
@qd-qd qd-qd force-pushed the fix/malleability branch from 3a10aaa to 204eec8 Compare April 4, 2024 09:12
@qd-qd qd-qd changed the title fix: point unicity 🐛 point unicity in validity check Apr 4, 2024
@qd-qd qd-qd merged commit 204eec8 into main Apr 4, 2024
@qd-qd qd-qd deleted the fix/malleability branch April 4, 2024 09:13
Copy link

github-actions bot commented Apr 4, 2024

Changes to gas cost

Generated at commit: 9f9da383f366626a27f19b73754491a93194c27d, compared to commit: 204eec86ef5856ca52a389c9b170cbb8922e02d9

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ImplementationCurve nModInv
pModInv
+6 ❌
+7 ❌
+0.03%
+0.03%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ImplementationCurve 146,107 (0) nModInv
pModInv
23,134 (0)
23,112 (0)
0.00%
0.00%
23,275 (+6)
23,235 (+7)
+0.03%
+0.03%
23,236 (+42)
23,214 (+42)
+0.18%
+0.18%
23,506 (0)
23,484 (0)
0.00%
0.00%
256 (0)
256 (0)

Copy link

github-actions bot commented Apr 4, 2024

LCOV of commit 204eec8 during Tests #218

Summary coverage rate:
  lines......: 48.2% (40 of 83 lines)
  functions..: 87.5% (7 of 8 functions)
  branches...: no data found

Files changed coverage rate:
                     |Lines       |Functions  |Branches    
  Filename           |Rate     Num|Rate    Num|Rate     Num
  =========================================================
  src/ECDSA256r1.sol |43.9%     41|66.7%     3|    -      0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant