Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/test with latest Go 1.22 for arm64 rather than x86 #6

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

chadlwilson
Copy link
Contributor

This is a common plugin, so updating this and building with latest Go for security reasons; including for arm64 platforms in preference to x86/32-bit.

@gaugebot
Copy link

gaugebot bot commented Mar 31, 2024

@chadlwilson Thank you for contributing to gauge_screenshot. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@chadlwilson chadlwilson marked this pull request as ready for review March 31, 2024 08:14
@chadlwilson
Copy link
Contributor Author

@sriv or @haroon-sheikh Does this look OK to you? This should also enable the auto-releasing for this plugin, and auto-updating gauge-repository.

There are no FTs that run for this plugin, but seems similar to other non-language plugins I infer?

@chadlwilson chadlwilson requested a review from sriv March 31, 2024 08:16
@chadlwilson chadlwilson force-pushed the modernize branch 2 times, most recently from cd2417d to 1e0b556 Compare March 31, 2024 08:25
Copy link

@haroon-sheikh haroon-sheikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@chadlwilson chadlwilson merged commit 4f45b90 into master Mar 31, 2024
7 checks passed
@chadlwilson chadlwilson deleted the modernize branch March 31, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants