Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side bar partial fails to honour site.Params.search #60

Open
phillxnet opened this issue Mar 17, 2024 · 0 comments · May be fixed by #61
Open

Side bar partial fails to honour site.Params.search #60

phillxnet opened this issue Mar 17, 2024 · 0 comments · May be fixed by #61

Comments

@phillxnet
Copy link
Contributor

When setting [params] 'search = false' the sidebar partial fails to honour this setting: resulting in an unexpected search item.

It is proposed that the expected behaviour is that of the functional header partial: where the search is disabled according to this parameter being set to false.

I am preparing a pull request to address this issue, and will present this shortly.
phillxnet added a commit to phillxnet/parsa-hugo that referenced this issue Mar 17, 2024
@phillxnet
Side bar partial fails to honour site.Params.search gethugothemes#60
b2a820a 
Ensure sidebar partial honours site.Params.search, as per
the header partial.
@phillxnet phillxnet linked a pull request Mar 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Side bar partial fails to honour site.Params.search #60 phillxnet/parsa-hugo
1 participant
@phillxnet