Grouping feature #133
Merged
Grouping feature #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for config refactor: moved dynamic class loading to separate fnuc
…ed test for config
Lasica
force-pushed
the
grouping-feature
branch
from
5493731
to
d2bb258
Compare
marrrcin
reviewed
Nov 20, 2023
marrrcin
reviewed
Nov 22, 2023
| node(some_operation, "C", "D", name="node3", tags=["baz"]), | ||
| ]) | ||
| ``` | ||
| The result will be 2 VertexAI nodes for this pipeline, first with name `nodegroup` that will run `node1` and `node2` Kedro nodes inside and provide output `C` and second VertexAI node: `node3`. Additional MLflow node can be present if `kedro-mlflow` is used. Right now it is not possible to group it. If you feel you need that functionality search for/create an issue on [github page of the plugin](https://github.com/getindata/kedro-vertexai/issues). |
There was a problem hiding this comment.
I think that it would be awesome to show the following thing in the documentation below the description:
- Screenshot of Kedro-viz of regular spaceflights pipeline
- Screenshot of code from e2e tests with tags (groups)
- Screenshot from Vertex AI
All side-by-side with arrows from one to another. Visualization always speaks better than a wall of text and people will know at glance what to expect.
There was a problem hiding this comment.
Ok I'll add the pictures.
marrrcin
reviewed
Nov 22, 2023
marrrcin
approved these changes
Nov 22, 2023
Lasica
force-pushed
the
grouping-feature
branch
from
e71bc72
to
71ff26d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added grouping nodes execution to single vertexai nodes. Updated docs.
PR Checklist