Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Replace context.tf with context provider and align with snowflake provider changes #20

Merged
merged 10 commits into from
Nov 5, 2024

Conversation

dgniewek
Copy link
Contributor

@dgniewek dgniewek commented Nov 4, 2024

This PR introduces a BREAKING CHANGE

List of code and variable (API) changes:

  • Removed context.tf file (a single-file module with additional variables), which implied a removal of all its variables (except name):
    • descriptor_formats
    • label_value_case
    • label_key_case
    • id_length_limit
    • regex_replace_chars
    • label_order
    • additional_tag_map
    • tags
    • labels_as_tags
    • attributes
    • delimiter
    • stage
    • environment
    • tenant
    • namespace
    • enabled
    • context
  • Remove support enabled flag - that might cause some backward compatibility issues with terraform state (please take into account that proper move clauses were added to minimize the impact), but proceed with caution
  • Additional context provider configuration
  • New variables were added, to allow naming configuration via context provider:
    • context_templates
    • name_schema

Additionally, due to breaking changes introduced in snowflake terraform provider v0.96.0 (snowflake_resource_monitor resource):

  • Removal of set_for_account variable / flag (will be settable on account resource)
  • Removal of warehouses variable (will be settable on warehouse resource)

@dgniewek dgniewek requested a review from a team November 4, 2024 14:40
outputs.tf Outdated Show resolved Hide resolved
dgniewek and others added 2 commits November 5, 2024 15:13
moss2k13
moss2k13 previously approved these changes Nov 5, 2024
@dgniewek dgniewek merged commit a4ce86b into main Nov 5, 2024
7 checks passed
@dgniewek dgniewek deleted the feature/remove_contest_and_provider_changes branch November 5, 2024 15:21
Copy link
Contributor

github-actions bot commented Nov 5, 2024

The new version v4.0.0 has been released 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants