refactor(indiekit): don’t return false from mongo config

getindiekit · Dec 24, 2023 · 1931bc6 · 1931bc6
1 parent fa84279
commit 1931bc6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/packages/indiekit/lib/mongodb.js b/packages/indiekit/lib/mongodb.js
@@ -16,7 +16,6 @@ export const getMongodbConfig = async (mongodbUrl) => {
       return database;
     } catch (error) {
       console.warn(error.message);
-      return false;
     }
   }
 };
diff --git a/packages/indiekit/tests/unit/mongodb.js b/packages/indiekit/tests/unit/mongodb.js
@@ -20,12 +20,11 @@ test("Connects to MongoDB database", async (t) => {
 
 test("Returns false if can’t connect to a MongoDB database", async (t) => {
   sinon.stub(console, "warn");
-  const result = await getMongodbConfig("https://foo.bar");
+  await getMongodbConfig("https://foo.bar");
 
   t.true(
     console.warn.calledWith(
       'Invalid scheme, expected connection string to start with "mongodb://" or "mongodb+srv://"',
     ),
   );
-  t.false(result);
 });