use separate job for browserstack

getlantern · Oct 18, 2023 · fd1c2df · fd1c2df
1 parent 6bdf083
commit fd1c2df
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 26 deletions.
diff --git a/.github/workflows/browerstack.yml b/.github/workflows/browerstack.yml
@@ -1,10 +1,6 @@
 name: BrowserStack CI
 
 on:
-  workflow_run:
-    workflows: ["release"]
-    types: 
-      - completed
 
 env:
   GOPRIVATE: github.com/getlantern

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -149,25 +149,7 @@ jobs:
       - name: Install jq
         run: sudo apt-get install jq
 
-      - name: Upload APK to BrowserStack
-        env:
-          BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
-          BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
-          BROWSERSTACK_APP_PATH: "lantern-installer.apk"
-        run: |
-          response=$(curl -u "$BROWSERSTACK_USERNAME:$BROWSERSTACK_ACCESS_KEY" \
-            -X POST "https://api-cloud.browserstack.com/app-automate/upload" \
-            -F "file=@$BROWSERSTACK_APP_PATH" \
-            -F "custom_id=LanternApp")
-          app_url=$(echo $response | jq -r .app_url)
-          echo "$app_url"
-          echo "BROWSERSTACK_APP_ID=$app_url" >> $GITHUB_ENV
-
-      - name: Run Tests
-        env:
-          BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
-          BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
-          RUN_ENV: "live"
-        run: |
-          cd appium_kotlin
-          ./gradlew test
+    browserstack:
+      uses: ./.github/workflows/browserstack.yml
+      secrets: inherit
+      needs: build-android