Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fronted ios #1258

Closed
wants to merge 7 commits into from
Closed

Fix fronted ios #1258

wants to merge 7 commits into from

Conversation

jigar-f
Copy link
Contributor

@jigar-f jigar-f commented Dec 10, 2024

The latest fronted code crashed on IOS, the Reason being we were not setting fronted, on Android it's set by flashlight, This Pr should fix that issue

fronted.go

// Use a wrapper for fronted.NewDirect to avoid blocking
// `dualFetcher.RoundTrip` when fronted is not yet available, especially when
// the application is starting up
func (f frontedRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
	if f.opName != "" {
		op := ops.Begin(f.opName)
		defer op.End()
	}
	return fronter.RoundTrip(req)
}

@jigar-f jigar-f closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants