Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests create a new "trees 20241231012345.csv" file in "~/Downloads" #1047

Open
sadiqkhoja opened this issue Nov 1, 2024 · 1 comment · May be fixed by #1122
Open

Tests create a new "trees 20241231012345.csv" file in "~/Downloads" #1047

sadiqkhoja opened this issue Nov 1, 2024 · 1 comment · May be fixed by #1122
Assignees
Labels
testing Integration tests, unit tests

Comments

@sadiqkhoja
Copy link
Contributor

Whenever I run npm run test, a new file "trees 20241231012345.csv" is created in my downloads folder. I guess it('has the correct filename') test in data-template.spec.js is the culprit.

@sadiqkhoja sadiqkhoja added the testing Integration tests, unit tests label Nov 1, 2024
@matthew-white
Copy link
Member

I actually noticed something along these lines while working on #671. When I run tests using Vitest on my local branch, a CSV file ends up being created in the repo (I'm pretty sure the same one). I didn't realize it had an effect even today under Karma. I fixed the issue in my local branch, I think by calling event.preventDefault() in the test. I'll go ahead and pull out that change into its own PR, since we can see that it's an issue even today.

@matthew-white matthew-white self-assigned this Nov 3, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Nov 3, 2024
sadiqkhoja added a commit to sadiqkhoja/central-frontend that referenced this issue Dec 31, 2024
sadiqkhoja added a commit to sadiqkhoja/central-frontend that referenced this issue Jan 6, 2025
sadiqkhoja added a commit to sadiqkhoja/central-frontend that referenced this issue Jan 8, 2025
@sadiqkhoja sadiqkhoja linked a pull request Jan 8, 2025 that will close this issue
2 tasks
sadiqkhoja added a commit to sadiqkhoja/central-frontend that referenced this issue Jan 10, 2025
sadiqkhoja added a commit to sadiqkhoja/central-frontend that referenced this issue Jan 10, 2025
sadiqkhoja added a commit to sadiqkhoja/central-frontend that referenced this issue Jan 10, 2025
 so we don't download the actual file
sadiqkhoja added a commit to sadiqkhoja/central-frontend that referenced this issue Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Integration tests, unit tests
Projects
Status: 🕒 backlog
Development

Successfully merging a pull request may close this issue.

2 participants