Warn about forms with old version of entity spec <2024.*

[ktuite]

When we migrate the entity form spec in existing entity forms we will not want to accept want to warn about new forms with an old entity spec.

From the above issue:

Once forms are migrated, we will need to check going forward that all form definitions that are uploaded (for new or existing forms) are capable of making offline changes. Specifically, we should reject form definitions that specify an entities spec before 2024.1. That shouldn't be an issue for users using XLSForms (things should work seamlessly), because pyxform will automatically specify 2024.1.

UPDATE: The issue mentioned rejecting form definitions, but we've decided to show a warning about them instead.

One hurdle users might encounter is if they have an old version of their form in XML and it has an old entity spec version. In that case, we can give users info on how to recover (e.g. download upgraded XML, look at spec to figure out changes to apply).

[matthew-white]

We've discussed that it'd be nice not to outright reject forms like this if doing so is not necessary. Instead, we can warn users if the form definition they've uploaded specifies an old spec. I'll update the description above.

Surfacing the warning in Frontend will probably require changes to Frontend. I've added the frontend label to the issue.

I've also removed the documentation label, since it isn't a docs issue. There's an issue at getodk/docs#1855 to update user docs, and an issue at getodk/central-backend#1211 to update API docs. Feel free to edit those!

[dbemke]

I'm not sure if this case works as expected - when I upload an old spec entity form which exists in the project first there's the dialog with information about the old spec (I tap "Upload anyway") and then the dialog with information that the form exists in a project appears. Should the dialog informing that the form already exists in the project be the first (and only) one?

Steps to reproduce:

1. Upload an old spec entity form and publish it.
2. Try to add the same form again.
3. The dialog with information about the spec appears, tap "Upload anyway"

[dbemke]

Should the warning about the old spec appear only when a user adds a new or also when adds a new version of a form (e.g changing the new spec to the old spec), undeletes the old spec form?

[ktuite]

It probably should warn when they upload a new version. (And it probably doesn't do that right now, does it? I can add that!)

Should the warning about the old spec appear only when a user adds a new or also when adds a new version of a form (e.g changing the new spec to the old spec), undeletes the old spec form?

Hmm, I see what you're saying with these two phases of dialog boxes. Knowing how it works under the hood, there isn't really a way to do something different. The first one about the version is a warning and the second is an error even though they are about different things.

I'm not sure if this case works as expected - when I upload an old spec entity form which exists in the project first there's the dialog with information about the old spec (I tap "Upload anyway") and then the dialog with information that the form exists in a project appears. Should the dialog informing that the form already exists in the project be the first (and only) one?

[dbemke]

It probably should warn when they upload a new version. (And it probably doesn't do that right now, does it? I can add that!)

The warning doesn't appear when a new version of a form is uploaded.
We finished testing. Should we wait for changes with the warning while adding a new version or is it going to be a separate issue?

[ktuite]

I've created a new issue! #816

The warning doesn't appear when a new version of a form is uploaded. We finished testing. Should we wait for changes with the warning while adding a new version or is it going to be a separate issue?

[ktuite]

Actually, we've decided to close the new #816 issue -- it requires too much of a code change to justify. You can evaluate this issue with just the functionality for new forms. Thanks!

[dbemke]

Tested with success!

[WKobus]

Tested with success!