[Issue #507] Allow non delegate users to declare interest in a patch #588
Conversation
|
I have seen this 👀 but I'm going to leave comments on the issue and discuss things there before looking at this. |
…o review a patch Users interested in reviewing a Patch are linked by the `planning_to_review` attribute on a Patch through the PatchReviewIntention model. Also added a field to State to indicate how long a review intention can last before it expires Signed-off-by: andrepapoti <[email protected]>
…rs to edit it Signed-off-by: andrepapoti <[email protected]>
…ning_to_review' field Signed-off-by: andrepapoti <[email protected]>
Signed-off-by: andrepapoti <[email protected]>
…e PatchReviewIntention for the commenting user Signed-off-by: andrepapoti <[email protected]>
…_review' field Signed-off-by: andrepapoti <[email protected]>
…'patchinterest' Signed-off-by: andrepapoti <[email protected]>
andrepapoti
force-pushed
the
i507
branch
3 times, most recently
from
4e1c212 to
2eb1ae1
Compare
Signed-off-by: andrepapoti <[email protected]>
|
I am not certain this solves #507. I can see from the code that there have been changes to model and patch structures to store users interested in the patch, but I don't see anywhere changes to actual user interface. I also run this code using docker-compose on my machine and I don't see any way to show interest in the patch? Am I missing something? |
|
@hero24 were you unable to declare interest on a patch when running it on a container? I missed to add a button for it on the UI, I'll add an extra commit with it |
|
@andrepapoti I will retest this later and let you know if it works through API for me, When I was testing this, I focused on web interface. I think most people use patchwork through web interface (it would actually be an interesting metric to conduct, but that beyond of the scope), but yes I could not find an add interest button through web, or any other way to declare interest through web interface. |
|
As I said earlier I gave this a run and tried looking at it through API. The code crashes, like the other PR, when I access through web |
Description
Add the relation between an user and a patch through the Patch's
interested_usersattribute.This relations happens through the model
PatchInterestthat contains a timestamp for when the interest was declared.Inside a
Patch'sStatethere's now an attribute indicating how long an interest can last before it expires.To remove expired interests async tasks were added using Celery
Serializers and Forms were update to reflect the changes aswell
Related