Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new cli library for mixins #2240

Open
carolynvs opened this issue Jul 11, 2022 · 1 comment
Open

Use new cli library for mixins #2240

carolynvs opened this issue Jul 11, 2022 · 1 comment
Assignees
Labels
2 - 🍕 Pizza should be eaten daily enhancement New code incoming!

Comments

@carolynvs
Copy link
Member

I'm working on a new library in porter to simplify creating a mixin or plugin. You can see the start of it in #2216. One nice feature in that PR is pkg/cli, which standardizes all the useful setup that we have in porter's main, and allows the mixins and plugins to get that same functionality without having to copy/paste it all.

Once that package is available in porter v1, we should use that for all the mixins (ideally making a mixin library just like I'm doing for plugins, but we can start with this package). When we switch to using pkg/cli, that will give us helper functions to load porter's configuration, and more easily bind flags like PORTER_DEBUG.

In my PR for #1429, I am keeping PORTER_DEBUG around for the mixins, but it would be great if we can use this and start having the mixins load porter's configuration, and then be able to use the same logic for "are we in debug mode" in porter, the plugins AND the mixins. This would also make it possible to do tracing from inside the mixins, since we could start passing opentelemetry environment variables and have them bound when the config is loaded.

@carolynvs carolynvs self-assigned this Jul 11, 2022
@carolynvs carolynvs added 2 - 🍕 Pizza should be eaten daily enhancement New code incoming! labels Jul 26, 2022
@carolynvs
Copy link
Member Author

After I cut 1.0.0 releases for the mixins, we can make this swap. Right now the mixins are all in RC and this is too big of a change for that.

@schristoff schristoff moved this to 📋 Backlog in Porter Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - 🍕 Pizza should be eaten daily enhancement New code incoming!
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant