Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dlq): Make InvalidMessage pickleable #284

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

nikhars
Copy link
Member

@nikhars nikhars commented Sep 13, 2023

We saw a crash in the ingest spans consumer because InvalidMessage is unpickleable. Make it pickleable to avoid the crash.

This should fix https://sentry.sentry.io/issues/4473581085/?project=1

We saw a crash in the ingest spans consumer because InvalidMessage is unpickleable.
Make it pickleable to avoid the crash.
@nikhars nikhars requested a review from a team as a code owner September 13, 2023 06:52
@nikhars nikhars requested a review from phacops September 13, 2023 06:52
@phacops phacops enabled auto-merge (squash) September 13, 2023 08:35
@phacops phacops merged commit 5b7df38 into main Sep 13, 2023
8 checks passed
@phacops phacops deleted the feat/make-invalid-message-pickleable branch September 13, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants