Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry.OpenTelemetry] SentrySpanProcessor does not ignore Sentry requests #3028

Closed
fastfend opened this issue Jan 9, 2024 · 5 comments
Closed

Comments

@fastfend
Copy link

fastfend commented Jan 9, 2024

Package

Other

.NET Flavor

.NET Core

.NET Version

8.0.0

OS

Any (not platform specific)

SDK Version

3.41.3

Self-Hosted Sentry Version

No response

Steps to Reproduce

  1. Use latest OpenTelemetry (version 1.7.0)
  2. Use AddHttpClientInstrumentation from OpenTelemetry.Instrumentation.Http
  3. Use AddSentry in OTEL tracing and UseOpenTelemetry in Sentry

Expected Result

Sentry should not include requests from HttpClient instrumentation to itself

Actual Result

HUGE amount of transactions (managed to obliterate my selfhosted sentry instance)
From my debug its because OTEL library no longer use http.url. They moved to url.full

Releated PRs:

@fastfend
Copy link
Author

fastfend commented Jan 9, 2024

I found that this was fixed in #3001. Can you tell what's the ETA of next release?

@fastfend
Copy link
Author

fastfend commented Jan 9, 2024

Also marking as duplicate of #2998

@bitsandfoxes
Copy link
Contributor

It's already been released in 4.0.0-beta.7 but I guess having to bump the major version of the SDK for the fix is not very appealing.
I'll see if we can backport it and get another 3.41.x out.

@Silvenga
Copy link

@bitsandfoxes we would like a backport - there appears to be a regression in beta.8 that breaks query tracking that I'm trying to track down.

@bitsandfoxes
Copy link
Contributor

Resolved in the 3.41.4 release. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants