From 8f5de3e6d119a12c2b2b1c08b7aab8eb01a78b67 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 20 Dec 2024 13:29:48 +0100 Subject: [PATCH] test(astro): Fix Astro 4 e2e test (#14816) In our Astro-4 E2E test app, Astro's Node adapter was pinned to a bad version that didn'T work correctly with newer Astro versions. We pinned the Astro version a while ago in https://github.com/getsentry/sentry-javascript/pull/14030 to unblock CI but looks like we just didn't follow up with investigating what caused the issue back then. This came up again when dependabot tried to bump the Astro version in #14781 and #14807 and as a result #14808 was opened. This PR now - bumps the Node adapter version which makes newer Astro version function properly again - updates `astro` to the latest v4 version (which is why I closed #14807) closes #14808 --- dev-packages/e2e-tests/test-applications/astro-4/package.json | 4 ++-- dev-packages/e2e-tests/test-applications/astro-4/src/env.d.ts | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/astro-4/package.json b/dev-packages/e2e-tests/test-applications/astro-4/package.json index 1aa316170a64..b80e408b3e32 100644 --- a/dev-packages/e2e-tests/test-applications/astro-4/package.json +++ b/dev-packages/e2e-tests/test-applications/astro-4/package.json @@ -13,12 +13,12 @@ }, "dependencies": { "@astrojs/check": "0.9.2", - "@astrojs/node": "8.3.2", + "@astrojs/node": "8.3.4", "@playwright/test": "^1.46.0", "@sentry/astro": "* || latest", "@sentry-internal/test-utils": "link:../../../test-utils", "@spotlightjs/astro": "2.1.6", - "astro": "4.13.3", + "astro": "4.16.18", "typescript": "^5.5.4" }, "devDependencies": { diff --git a/dev-packages/e2e-tests/test-applications/astro-4/src/env.d.ts b/dev-packages/e2e-tests/test-applications/astro-4/src/env.d.ts index f964fe0cffd8..acef35f175aa 100644 --- a/dev-packages/e2e-tests/test-applications/astro-4/src/env.d.ts +++ b/dev-packages/e2e-tests/test-applications/astro-4/src/env.d.ts @@ -1 +1,2 @@ +/// ///