Skip to content

Commit dcd6345

Browse files
committed
Address review comments
1 parent aa7c861 commit dcd6345

File tree

3 files changed

+5
-40
lines changed

3 files changed

+5
-40
lines changed

packages/node/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"access": "public"
6666
},
6767
"dependencies": {
68-
"@fastify/otel": "0.5.0",
68+
"@fastify/otel": "0.5.1",
6969
"@opentelemetry/api": "^1.9.0",
7070
"@opentelemetry/context-async-hooks": "^1.30.1",
7171
"@opentelemetry/core": "^1.30.1",

packages/node/src/integrations/tracing/fastify/index.ts

-35
Original file line numberDiff line numberDiff line change
@@ -16,41 +16,6 @@ import * as diagnosticsChannel from 'node:diagnostics_channel';
1616
import { DEBUG_BUILD } from '../../../debug-build';
1717
import type { FastifyInstance, FastifyReply, FastifyRequest } from './types';
1818

19-
// /**
20-
// * Minimal request type containing properties around route information.
21-
// * Works for Fastify 3, 4 and presumably 5.
22-
// *
23-
// * Based on https://github.com/fastify/fastify/blob/ce3811f5f718be278bbcd4392c615d64230065a6/types/request.d.ts
24-
// */
25-
// // eslint-disable-next-line @typescript-eslint/no-explicit-any
26-
// interface MinimalFastifyRequest extends Record<string, any> {
27-
// method?: string;
28-
// // since [email protected]
29-
// routeOptions?: {
30-
// url?: string;
31-
// };
32-
// routerPath?: string;
33-
// }
34-
35-
// /**
36-
// * Minimal reply type containing properties needed for error handling.
37-
// *
38-
// * Based on https://github.com/fastify/fastify/blob/ce3811f5f718be278bbcd4392c615d64230065a6/types/reply.d.ts
39-
// */
40-
// // eslint-disable-next-line @typescript-eslint/no-explicit-any
41-
// interface MinimalFastifyReply extends Record<string, any> {
42-
// statusCode: number;
43-
// }
44-
45-
// // We inline the types we care about here
46-
// interface Fastify {
47-
// // eslint-disable-next-line @typescript-eslint/no-explicit-any
48-
// version: string;
49-
// register: (plugin: any) => Fastify;
50-
// after: (listener?: (err: Error) => void) => Fastify;
51-
// addHook: (name: string, handler: (...params: unknown[]) => void) => Fastify;
52-
// }
53-
5419
interface FastifyHandlerOptions {
5520
/**
5621
* Callback method deciding whether error should be captured and sent to Sentry

yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -3921,10 +3921,10 @@
39213921
resolved "https://registry.yarnpkg.com/@fastify/busboy/-/busboy-2.0.0.tgz#f22824caff3ae506b18207bad4126dbc6ccdb6b8"
39223922
integrity sha512-JUFJad5lv7jxj926GPgymrWQxxjPYuJNiNjNMzqT+HiuP6Vl3dk5xzG+8sTX96np0ZAluvaMzPsjhHZ5rNuNQQ==
39233923

3924-
"@fastify/[email protected].0":
3925-
version "0.5.0"
3926-
resolved "https://registry.yarnpkg.com/@fastify/otel/-/otel-0.5.0.tgz#1b18e9623768ad6d8a20e95771dacca2783aa0ba"
3927-
integrity sha512-wZ2yl/2iuW6jerdktR/mpkkI83/qHhbRShQtNA3x+6+bQ/RKqmhifc5M29fmHbyIw+DF3SXJAKMSdURSQt4W0w==
3924+
"@fastify/[email protected].1":
3925+
version "0.5.1"
3926+
resolved "https://registry.yarnpkg.com/@fastify/otel/-/otel-0.5.1.tgz#fc8e56fcbdeb693c1a44f2da071817bc600ae1f5"
3927+
integrity sha512-xDoDFQHRlgZ1Koe9fWzz4MqgrdW6u66bMPy+rOgoWg4cHyGFnmpcnUusKaFOyBsFhGtaH5dCLmLo3gCGoMnxYQ==
39283928
dependencies:
39293929
"@opentelemetry/core" "^1.29.0"
39303930
"@opentelemetry/instrumentation" "^0.57.0"

0 commit comments

Comments
 (0)