feat(nestjs): Gracefully handle RPC scenarios in SentryGlobalFilter
#16066
+292
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT:
Circled back on the approach of adding a
SentryRpcFilter
:SentryGlobalFilter
which then tried to handle RpcExceptions in a http manner. This is why we got this weird error.SentryGlobalFilter
to more gracefully handle these scenarios and add a warning log that users should provide their own RrcException filter – will also update this in docs.closes #16051