Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new captureFeedback API to RN SDK #3859

Closed
Tracked by #4302
dalnoki opened this issue Jun 5, 2024 · 3 comments · Fixed by #4320
Closed
Tracked by #4302

Add new captureFeedback API to RN SDK #3859

dalnoki opened this issue Jun 5, 2024 · 3 comments · Fixed by #4320

Comments

@dalnoki
Copy link

dalnoki commented Jun 5, 2024

Description

This function is the base functionality needed to allow capturing user feedback while including tags, replay_id, trace_id, etc.
It's part of the 'new user feedback' product (getsentry/sentry#64671) that was shipped for Web. That included a built-in widget, that allows screenshot attachment, and under the hood relies on this new function that deprecates the old captureUserFeedback which required an event_id. The new function optionally takes a related event_id and will contain relevant context stand alone.

Since RN is built on top of the JS SDK we might be able to re-export the function. But we need to verify that connection to tracing and replays will work properly. See:

This means a new envelope format for feedback was introduced.
The new Feedback product architecture has thoroughly documented by @aliu39 here:

This new function will allow outgoing feedbacks to be tied to Session Replay, which is currently Open Beta and we're working on GA:

The develop docs have not been added yet, but the ticket with details about it is here:

Relates to:

@bruno-garcia
Copy link
Member

@krystofwoldrich
Copy link
Member

The API without UI, will be available in RN SDK v6 (the next major) which includes JS v8 which includeds the new captureFeedback API.

@krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich changed the title Add new captureFeedback to RN SDK Add new captureFeedback API to RN SDK Nov 22, 2024
@antonis antonis moved this from Backlog to In Progress in Mobile & Cross Platform SDK Nov 25, 2024
@antonis antonis moved this from In Progress to Needs Review in Mobile & Cross Platform SDK Nov 27, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Mobile & Cross Platform SDK Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants