Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Truncation Logic for Custom contexts #2381

Open
kerenkhatiwada opened this issue Aug 16, 2024 · 0 comments
Open

Implement Truncation Logic for Custom contexts #2381

kerenkhatiwada opened this issue Aug 16, 2024 · 0 comments
Assignees
Labels
enhancement Sync: Jira apply to auto-create a Jira shadow ticket

Comments

@kerenkhatiwada
Copy link
Member

kerenkhatiwada commented Aug 16, 2024

Describe the idea

Reported by user: Currently, the sentry-ruby SDK truncates messages sent via Sentry.capture_exception and Sentry.capture_message to 8 KB, utilizing the Sentry::Event::MAX_MESSAGE_SIZE_IN_BYTES constant. However, this truncation logic is not applied to data stored in the Sentry::Scope @extra hash, which can bypass these checks and lead to oversized events being dropped without notification.

The request is that the sentry-ruby SDK truncations logic for strings stored in the Custom contexts. This would ensure that large messages added to the Custom contexts are handled similarly to messages, preventing potential data loss and ensuring consistency across the SDK.

Why do you think it's beneficial to most of the users

users will be better protected from silent event drops due to oversized data

Possible implementation

┆Issue is synchronized with this Jira Improvement by Unito

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Aug 16, 2024
@kerenkhatiwada kerenkhatiwada added the Sync: Jira apply to auto-create a Jira shadow ticket label Aug 16, 2024
@sl0thentr0py sl0thentr0py self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Sync: Jira apply to auto-create a Jira shadow ticket
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

2 participants