Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails: ActiveSupport notification subscriptions should be spans #2398

Open
nateberkopec opened this issue Sep 10, 2024 · 2 comments
Open

Rails: ActiveSupport notification subscriptions should be spans #2398

nateberkopec opened this issue Sep 10, 2024 · 2 comments

Comments

@nateberkopec
Copy link
Contributor

Currently, a lot of ActiveSupport notifications are used to create breadcrumbs

I think pretty much all of these would also be useful spans, particularly the cache stuff.

@frederikspang
Copy link
Contributor

Cache is being worked on in #2380 - Not as breadcrumb :)

@sl0thentr0py
Copy link
Member

thx @nateberkopec, we could definitely update our list to include more spans. I'm a bit wary of including everything because

  • we had serialization problems in the past with some of them
  • in other languages, we've had some spans that just act as noise so I'd like to avoid high volume stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants