Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align user.ip between reporting SDKs #755

Closed
vaind opened this issue May 19, 2022 · 5 comments
Closed

Align user.ip between reporting SDKs #755

vaind opened this issue May 19, 2022 · 5 comments

Comments

@vaind
Copy link
Collaborator

vaind commented May 19, 2022

Depending on what SDK captures the event, there may be an IP address included for a given user (ID). We should align that to be the same across all types or events. AFAICT the IP address is there only for the cocoa SDK. The questions, for me, are:

  1. should we include the IP address by default? -- depending on the setting.
  2. should it depend on the "DefaultPII" setting? -- yes
@vaind
Copy link
Collaborator Author

vaind commented May 31, 2022

It's done by the server for sentry-cocoa for historic reasons - can we turn it off on the server for Unity projects?

@vaind
Copy link
Collaborator Author

vaind commented May 31, 2022

maybe workaround: try to send an empty string as the IP address

@vaind vaind moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK May 31, 2022
@bitsandfoxes bitsandfoxes added this to GDX Mar 13, 2024
@bitsandfoxes bitsandfoxes changed the title Align user.ip between error types Align user.ip between reporting SDKs Oct 23, 2024
@bitsandfoxes
Copy link
Contributor

We're populating the user in our ScopeIntegration here

private void PopulateUser(Scope scope)
{
if (_options.DefaultUserId is not null)
{
if (scope.User.Id is null)
{
scope.User.Id = _options.DefaultUserId;
}
}
}

Any alignment of what else happens to the user seems to be required on the .NET SDK.

@bitsandfoxes
Copy link
Contributor

The underlying SDKs should definitely align on when and what gets sent. And if this depends on the options provided to them (i.e. SendPII) then the Unity SDK must have appropriate default values.

@bitsandfoxes
Copy link
Contributor

Resolved in the .NET SDK via getsentry/sentry-dotnet#3893
Coss-SDK tracking: getsentry/team-sdks#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Archived in project
Development

No branches or pull requests

2 participants