Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search through debug_meta fields (like code_file) in order to match .exe-cutable #83608

Open
malkia opened this issue Jan 16, 2025 · 3 comments

Comments

@malkia
Copy link

malkia commented Jan 16, 2025

Problem Statement

Normally when we have a crash in an .exe, we can use stack.package:*tool.exe* and it'll find instances with the crash. Unfortunately it may not find all instances, under some circumstatnces.

Suppose that tool.exe loads helper.dll and crashes there in such way that tool.exe is not in the crashed callstack (for example the .dll creates it's own thread, and only calls within the module are done).

This prevents us from finding all crashes using stack.package:*tool.exe*.

Thanks!

Solution Brainstorm

Two ways comes to mind:

  1. sentry already saves some bits about the image in the debug_meta fields, like debug_meta.code_file[] where all loaded .exe, .dll etc. are stored. So if we allow search through these, then we would be able to find all isntances. TBH, doesn't have to be really the debug_meta field, it can be some synthetic field made after processing.

  2. Alternatively, if the other (non-crashing) stacks were searchable, then most likely at least one of the stacks would've contained *tool.exe* (maybe apart from rare case, where we've ended up with process that has only threads without the .exe itself - not sure if this can happen, and I'm speaking from Windows side, on other systems might be different).

Product Area

Discover

@getsantry
Copy link
Contributor

getsantry bot commented Jan 16, 2025

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Jan 17, 2025

Routing to @getsentry/product-owners-issues for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 17, 2025
@leeandher
Copy link
Member

Thanks for the feedback! I'm not super familiar with native crash reporting, but it's common request to add more data to what is indexed and searchable across the Sentry product. Unfortunately at the moment the team doesn't have the bandwidth to prioritize this, but I'll ensure it gets added to our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants