From 169805b5b7d6920e3ac1219efee2b8cddc35946d Mon Sep 17 00:00:00 2001 From: Rotem Yaari Date: Sat, 9 Mar 2019 21:19:40 +0200 Subject: [PATCH 1/2] Revert "Fix background color on white terminals (closes #925)" This reverts commit 831e028d694845286302f8cc090f3c73d62ca8ba. --- doc/changelog.rst | 1 - slash/reporting/console_reporter.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/changelog.rst b/doc/changelog.rst index e1f80955..286d7b7c 100644 --- a/doc/changelog.rst +++ b/doc/changelog.rst @@ -2,7 +2,6 @@ Changelog ========= * :release:`1.7.8 <04-03-2019>` -* :bug:`925` Fix background color for session start and test collection messages * :bug:`926` Return code for failed sessions was changed to 1 (from -1) * :release:`1.7.7 <21-01-2019>` * :bug:`907` Fix parallel worker timeout issues diff --git a/slash/reporting/console_reporter.py b/slash/reporting/console_reporter.py index a284ef84..2d0be039 100644 --- a/slash/reporting/console_reporter.py +++ b/slash/reporting/console_reporter.py @@ -166,14 +166,14 @@ def _report_num_collected(self, collected, stillworking): return self._terminal.write('{} tests collected{}'.format( - len(collected), '...' if stillworking else ' \n'), white=True, bold=True, Black=True) + len(collected), '...' if stillworking else ' \n'), white=True, bold=True) def _is_verbose(self, level): return self._level <= level @from_verbosity(VERBOSITIES.ERROR) def report_session_start(self, session): - self._terminal.sep('=', 'Session starts', white=True, bold=True, Black=True) + self._terminal.sep('=', 'Session starts', white=True, bold=True) def report_session_end(self, session): From daa618a236da447dceeb25d7bd0409149c1d2f65 Mon Sep 17 00:00:00 2001 From: Rotem Yaari Date: Sat, 9 Mar 2019 22:13:49 +0200 Subject: [PATCH 2/2] Changelog --- doc/changelog.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/changelog.rst b/doc/changelog.rst index 286d7b7c..d195ad40 100644 --- a/doc/changelog.rst +++ b/doc/changelog.rst @@ -1,7 +1,10 @@ Changelog ========= +* :release:`1.7.9 <09-03-2019>` +* :bug:`-` Revert console coloring change, as it does not behave consistently across different terminals * :release:`1.7.8 <04-03-2019>` +* :bug:`925` Fix background color for session start and test collection messages * :bug:`926` Return code for failed sessions was changed to 1 (from -1) * :release:`1.7.7 <21-01-2019>` * :bug:`907` Fix parallel worker timeout issues